✏️ 쿠폰 발급완료 사용여부 수정, 쿠폰조회 중복 수정 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
서브쿼리로 로직이 변경되어서 조인을 할 필요가 없었는데 이를 삭제하지 않아 프론트에서 쿠폰을 볼 때 유저마다의 쿠폰정보가 보이는 문제가 발생했었음
catch에서 에러를 throw하면 ack를 하지 못해 계속해서 알림이 발송됨. 또한 해당 메서드는 controller의 호출을 받지 않아 Controller Advice에서 처리가 불가능해 throw하지 않는게 맞음
Order에서 null을 허용한 채로 요청을 넘기도록 변경해 이를 판별하는 로직 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
PR 유형
어떤 변경 사항이 있나요? ✅
스크린 샷
PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.